search

Haplo064 / ChatBubbles

GNU General Public License v3.0
29 stars 31 forks source link

Handle null reference exception #55

Closed NPittinger closed 1 year ago

NPittinger commented 1 year ago

Resolves the following error by checking for null pointers before trying to access objects.

[ChatBubbles] Error before updating frame: System.NullReferenceException: Object reference not set to an instance of an object.
   at FFXIVClientStructs.FFXIV.Component.GUI.AtkResNode.get_IsVisible() in D:\a\Dalamud\Dalamud\lib\FFXIVClientStructs\FFXIVClientStructs\FFXIV\Component\GUI\AtkResNode.cs:line 104
   at ChatBubbles.ChatBubbles.OnceUponAFrame(Object _) in /work/repo/ChatBubbles/OnceUponAFrame.cs:line 189
MKhayle commented 1 year ago

Thanks for this PR ! I had plans to change it myself next version with a different approach, but that works too. Merging it now, but I may take a bit more time to push an update for a new version on the main repo.