HappenApps / Quiver

Quiver documentation and issue tracker
2.26k stars 109 forks source link

When I change notebooks, the app didn't change note. #1201

Closed letswritetw closed 5 years ago

letswritetw commented 5 years ago

I update to Version3.2 today, and then I can not change note when I change notebooks, like this: bug demo video

edding commented 5 years ago

Having the same issue here. Also I found sometimes the editing window just freeze there.

jinphen commented 5 years ago

+1

ylian commented 5 years ago

Investigating.

ylian commented 5 years ago

Might have to do with the custom theme you installed. Which theme is it?

ylian commented 5 years ago

Guess it's this one: Orange Dark theme. Testing.

ylian commented 5 years ago

Nope. That's not it. Possible to send me your Quiver library? If no sensitive information in it. Email: ylian@happenapps.com

lctrcl commented 5 years ago

Can confirm that this is what I have after update as well, no custom themes.

letswritetw commented 5 years ago

Nope. That's not it. Possible to send me your Quiver library? If no sensitive information in it. Email: ylian@happenapps.com

My library are save in dropbox. I'll send you the url to your email.

I find something, when I copy library and save it as new file, then open the new library, everything is back to normal. It's can change note again.

ylian commented 5 years ago

@auguston Thanks for sending me your Quiver library. I can open the library and switch notebooks, so it looks like an issue with the initial migration. Keep investigating...

ylian commented 5 years ago

@auguston Aha, found something. Some of your notebook names are lowercased and some uppercased. That might have caused the problem during the initial migration.

jinphen commented 5 years ago

when i move out Quiver library from icloud, it works. but move back to icloud, it show bugs.

letswritetw commented 5 years ago

@auguston Aha, found something. Some of your notebook names are lowercased and some uppercased. That might have caused the problem during the initial migration.

I change library name "Quiver.qvlibrary" to "quiver.qvlibrary", also work. My notebooks almost use chinese name, so I change library name first.

ylian commented 5 years ago

Yep, I am confident I found the culprit. The reason is a tiny renaming I did to the sortKey from "created_at" to "createdAt", but I forgot to convert that during the initial migration. So if you have set custom sort orders of a notebook to created_at or updated_at before, after initial migration, you will run into this bug.

This can be easily fixed on my end. Will confirm the fix with more users, and push it out right away.

ylian commented 5 years ago

Tentatively stopped the Quiver 3.2 rollout. Submitting 3.2.1 right now.

ylian commented 5 years ago

The build I posted a few minutes ago is not a complete fix. Will post another one here shortly.

ylian commented 5 years ago

Submitted 3.2.1 build 178 with the proper fix.

In the meantime, if you are experiencing this bug, you can use this build:

https://www.dropbox.com/s/ml0mdwsvea6diw2/Quiver%203.2.1%20Build%20178.zip?dl=0

ewadegam commented 5 years ago

@ylian 3.2.1 build 178 didn't fix it for me. When switching notes in the three pane view, the editor section keeps being empty. After a restart of Quiver it works. As soon as I CMD+W the Quiver wIndow and get back to it afterwards, it's broken.

As in #1203.

ylian commented 5 years ago

@rebewnitram That's a different bug. Let's continue the discussion in #1203. I haven't yet got enough feedback to figure out that bug, but maybe you can help me.

ylian commented 5 years ago

@rebewnitram A screenshot or screen recording would be very helpful.

ylian commented 5 years ago

@rebewnitram Actually I reproduced it! As you said, cmd+w then go back! Appreciate it!

ewadegam commented 5 years ago

You're welcome.

ylian commented 5 years ago

Fixed in 3.2.1. Appreciate everyone's help to fix this bug. 👍

ylian commented 5 years ago

Also please delete the previous builds I sent, and download the official version from the App Store.