search

HappenApps / Quiver

Quiver documentation and issue tracker
2.26k stars 109 forks source link

Text Services don't work in Markdown/Code cells: selection not passed to service #163

Open lastobelus opened 9 years ago

lastobelus commented 9 years ago

The easiest way to reproduce this issue is with the built-in Service, Make New Sticky Note.

With a text cell, a new note will be created with the selected text.

With a markdown or code cell, a new note is created but it is empty.

Issue is present on both release and 3.0 beta.

(note: I have no interest in creating sticky notes, but I would like to use Brett Terpstra's markdown services and searchlink service in markdown cells, and they all have the same issue)

ylian commented 9 years ago

It's an issue with the Ace editor. I will seriously dig into the Ace source code sometime and fix these bugs.

ylian commented 9 years ago

Try it here: http://ace.c9.io/build/kitchen-sink.html It has the same problem.

lastobelus commented 9 years ago

Issues on ace: ajaxorg/ace#2662, ajaxorg/ace#2446

ylian commented 9 years ago

Thanks. I will spend some time working on Ace after Quiver 3.0. It seems that Ace needs some help.