Crash when applying bullet points on multiple lines of text

HappenApps / Quiver

Quiver documentation and issue tracker

2.26k stars 109 forks source link

Crash when applying bullet points on multiple lines of text #21

Open LeonardoGentile opened 9 years ago

LeonardoGentile commented 9 years ago

STEPS:

create a text cell
create multiple lines of text, for example 3 short sentences. The last line should be at the bottom of the cell, meaning that there shouldn't be any empty line after it
selected these lines and apply either ordered or unordered bullet points

RESULT: The spinning wheel will appear and spin forever until we force quit the application. Most probably quiver is trying to create another extra bullet/point after the last line but there isn't enough space because we are at the cell bottom.

ylian commented 9 years ago

This is not happening to me. Which system version and computer are you using?

ylian commented 9 years ago

I think the hang comes from WebKit. Can you send me the WebKit version?

Open /System/Library/Frameworks/WebKit.framework/Resources/Info.plist and send me the "Bundle version".

LeonardoGentile commented 9 years ago

Hi the Bundle Version of webkit is 9537.78.2

ylian commented 9 years ago

I am using 10600.1.25. Are you running 10.9? I think the hang happens when WebKit tries to adjust the layout but ran into an infinite loop. Google search showed that this bug happened in WebKit before. I am not interested in fixing WebKit, but maybe I can change my CSS a bit to avoid this issue.

A few things that will help me:

Does this happen to any note?
Quit Quiver and reopen, does it still happen?
Adjust the window size, does it still happen?

LeonardoGentile commented 9 years ago

Sorry this happened on another computer today, so I gave you the wrong webkit version. In fact on this machine the problem doesn't happen.

I'll be more specific tomorrow by checking the faulty machine. Thanks for your support!

ylian commented 9 years ago

No problem. I have seen a couple hang reports very similar to this one on iTunes Connect, and the issue seems to go away by itself after a few days. I am guessing a very specific layout and/or WebKit version caused this issue. From the hang reports, it's clear the bug comes from within WebKit, and the app hangs because WebKit tries to do a re-layout, but runs into an infinite loop.

I haven't been able to reproduce this issue myself, so any help on debugging this issue is greatly appreciated.

LeonardoGentile commented 9 years ago

On the machine causing the problem the bundle version is 9537.78.2 the same as the other machine that is not giving the problem.

For answering your other questions: 1.Both on Mavericks 2.Yes

Couldn't test it

The problem is that today I can't reproduce the error, so most probably it was related to a specific note or a specific text cell..I'll try to take more details in case it will happen again, sorry But I can surely tell you that yesterday I had to force quit the app at least 10 times due to this (always on the same note and cell)

ylian commented 9 years ago

Must be a specific layout or something. A very obscure bug indeed. Let me know when you have more information.

janodev commented 9 years ago

Happened to me once on Yosemite beta 10.10.3, bundle 10600.5.3.1 but I’m unable to reproduce it.

ylian commented 9 years ago

I will dig more into this issue in Quiver 2.2. I have some logs but they point to a layout bug deep inside WebKit. Anyone who has more insights or can reproduce this issue, please post here.

jaysoffian commented 5 years ago

I think I'm seeing the same issue. I took a sample while it's beachballed.

Sample of Quiver.txt

ghost commented 4 years ago

The infinite loop is in function InsertListCommand::doApply(). I verified it with a dynamic patch leveraging lldb. It is relate to bug https://bugs.webkit.org/show_bug.cgi?id=210354 I hope this information provides hints to avoid the bug for webcore versions behind the fix.