Happy0 / ssb-chess

A library for building scuttlebutt chess clients with
GNU General Public License v2.0
63 stars 16 forks source link

style history to have the usernames above the moves #26

Closed frankiebee closed 7 years ago

frankiebee commented 7 years ago

just a style tweak so i can read stuff better

Happy0 commented 7 years ago

Layout looks good :).

One small thing needs fixed though. At the moment, if you're playing as black then it'll put your name on the left column (making it look as though you played the first move.) This is because I'd originally make it so that the player at the top was first, and then the player at the bottom below it.

To fix this, I'd change lines 38 and 39 to be 'whitePlayer' and 'blackPlayer' and do coloursToPlayers("white")' and coloursToPlayers("black") for each, if that makes sense?

Happy0 commented 7 years ago

Update looks good. I'll give it a test when I get home a bit later, then merge if it works. :)

Happy0 commented 7 years ago

Fanx :+1:

:D