search

HappyPorch / uSplit

A/B Testing plugin for Umbraco
The Unlicense
11 stars 7 forks source link

It is possible to have two experiments with the same name, in my test… #1

Closed vdwert closed 8 years ago

vdwert commented 8 years ago

… scenario I had two, one running, and an old version which was stopped. The previous logic selected the first which was stopped and the experiment was not being run.

ondrejpialek commented 8 years ago

Hi Marc!

Thanks a lot for pointing this out. I remember dealing with a similar problem in the past - the variations also did not have a unique name in the past and that was causing some issues.

I need to spend some more time analyzing the code. There is a greater problem - what would happen if you had more active experiments for a single page... Theoretically we could support that, but only with extra dev which I am not sure is warranted yet.

I would have accepted if your PR if didn't remove the IsValidExperiment check (it definitely needs some refactoring, just want to keep things separate).

Thanks, Ondrej.

ondrejpialek commented 8 years ago

Merged & did some refactoring of the caching. Thanks @vdwert

vdwert commented 8 years ago

Hi Ondrej,

Thanks for accepting my pull request! Expect more if I have the time!

Greetings!

Marc