HappyTobi / cf-puppeteer

CF-Puppeteer is a zero-downtime deployment plugin bases on autopilot
https://cf-puppeteer.happytobi.com
Apache License 2.0
17 stars 4 forks source link

Command defaults to --no-route and --no-start #24

Closed iKrushYou closed 4 years ago

iKrushYou commented 4 years ago

For some reason, it looks like it's defaulting to --no-route and --no-start even though I don't specify it

compass-api akrush$ cf zero-downtime-push compass -f manifest-dev.yaml --legacy-push
Deleting app compass in org TZU0 / space tzu0_dev as akrush...
OK
Use legacy push
start pushing application with arguments [push compass -f manifest-dev.yaml --no-start --no-route]
---
default_envs: &default_envs
  SPRING_PROFILES_ACTIVE: cloud,dev
  TZ: GMT
defaults: &defaults
  buildpacks:
    - java_buildpack_offline
  env:
    *default_envs
  timeout: 120
  services:
    - jasypt-service
applications:
  - name: armada-compass
    <<: *defaults
    path: target/compass-0.0.1-SNAPSHOT.jar

Update: It seems like those flags specified in the output are a red herring. However, I can't explain how but now the app seems to start on its own. I have also found that the route only pushes if it's explicitly set. It won't push a default route if I leave the routes blank. Is there a way around this?

HappyTobi commented 4 years ago

Hi @iKrushYou,

yes that arguments will be used for each push but that's only one on many steps the plugin has till your application will run as expected.

So maybe it's better to mark that output as Information or Step [1/10] or something like that.

The default setting when you push you application will be the same as cf push so you application will start after the deployment. default:

If you want to change one of the behaviors you can pass: --no-start or --no-route to change that. See also the documentation here: documentation

Hope that helps. Kind regards

iKrushYou commented 4 years ago

Hey thanks for the quick response. I still seem to be experiencing issues with an implicit route. With my manifest as is (above) it doesn't add the default route.

HappyTobi commented 4 years ago

Hi @iKrushYou,

you mean that or: https://docs.cloudfoundry.org/devguide/deploy-apps/deploy-app.html#default-route CF-Puppeteer doesn't generate any default route for you sorry, you have to put that into your manifest.

iKrushYou commented 4 years ago

@HappyTobi yes I believe that's exactly it

Okay, so just to make sure we're on the same page here..

Do you think it might make sense to update the readme or documentation to clarify this? I tried searching before posting but wasn't able to find anything specific to the routes

Thanks!

HappyTobi commented 4 years ago

@iKrushYou

Yes that make totally sense. Will you create a PR or I will add that later.

I also think about print out a small summary before the application will be deployed. (feature for the next version maybe)

Kind regards

iKrushYou commented 4 years ago

Sure thing, let me know if https://github.com/HappyTobi/cf-puppeteer/pull/25 looks okay

HappyTobi commented 4 years ago

@iKrushYou fine thx. I add a comment to the pr.

Think the issue can be closed, if there is something else, feel free to open a new issue.

Kind regards