Closed iKrushYou closed 4 years ago
Hi @iKrushYou,
yes that arguments will be used for each push but that's only one on many steps the plugin has till your application will run as expected.
So maybe it's better to mark that output as Information
or Step [1/10]
or something like that.
The default setting when you push you application will be the same as cf push
so you application will start after the deployment.
default:
If you want to change one of the behaviors you can pass:
--no-start
or --no-route
to change that.
See also the documentation here: documentation
Hope that helps. Kind regards
Hey thanks for the quick response. I still seem to be experiencing issues with an implicit route. With my manifest as is (above) it doesn't add the default route.
Hi @iKrushYou,
you mean that or: https://docs.cloudfoundry.org/devguide/deploy-apps/deploy-app.html#default-route
CF-Puppeteer doesn't generate any default route for you sorry, you have to put that into your manifest
.
@HappyTobi yes I believe that's exactly it
Okay, so just to make sure we're on the same page here..
cf push
by default WILL generate a default route for each appcf-puppeteer
will NOT generate a default route and therefore at least one must be explicitly specifiedDo you think it might make sense to update the readme
or documentation to clarify this? I tried searching before posting but wasn't able to find anything specific to the routes
Thanks!
@iKrushYou
Yes that make totally sense. Will you create a PR or I will add that later.
I also think about print out a small summary before the application will be deployed. (feature for the next version maybe)
Kind regards
Sure thing, let me know if https://github.com/HappyTobi/cf-puppeteer/pull/25 looks okay
@iKrushYou fine thx. I add a comment to the pr.
Think the issue can be closed, if there is something else, feel free to open a new issue.
Kind regards
For some reason, it looks like it's defaulting to
--no-route
and--no-start
even though I don't specify itUpdate: It seems like those flags specified in the output are a red herring. However, I can't explain how but now the app seems to start on its own. I have also found that the route only pushes if it's explicitly set. It won't push a default route if I leave the routes blank. Is there a way around this?