Happyculture / combawa

Helper to set up Drupal projects and build them all along their life.
GNU General Public License v3.0
14 stars 2 forks source link

Support UTF-8 chars for passwords encoding? #100

Closed Artusamak closed 10 months ago

Artusamak commented 2 years ago

I generated an environment file with those chars in my password: ù and §. They are dropped in the end when then .env file is generated. That's a problem since we loose some chars and the connection to the DB is then broken.

Find out how to increase support for those chars.

The ultimate solution would be to forbid some chars but that's not what we'd like.

Besfr commented 2 years ago

The issue could be the usage of escapeshellarg that strip non-ASCII char. There is some comments in the doc page https://www.php.net/manual/fr/function.escapeshellarg.php about that or some fixes to test in the wild : https://markushedlund.com/dev/php-escapeshellarg-with-unicodeutf-8-support/

Artusamak commented 1 year ago

Escape::shellArg() from consolidation/site-process should do the work.

Blocked by #70 to fully test.

Artusamak commented 1 year ago

For a side test, i confirm that it works, the output is well protected and escaped.