Add createQueryBuilder() abstract method in EntitySpecificationRepositoryTrait

Happyr / Doctrine-Specification

This library gives you a new way for writing queries. Using the Specification pattern you will get small Specification classes that are highly reusable.

MIT License

446 stars 41 forks source link

Add createQueryBuilder() abstract method in EntitySpecificationRepositoryTrait #225

Closed peter-gribanov closed 3 years ago

peter-gribanov commented 5 years ago

It seems like createQueryBuilder() must be provided by classes using this trait. How about adding it as abstract method to this trait? Filename: src/EntitySpecificationRepositoryTrait.php LineNumber: 148 Link: https://scrutinizer-ci.com/g/Happyr/Doctrine-Specification/issues/master/files/src/EntitySpecificationRepositoryTrait.php?selectedLabels%5B0%5D=9&orderField=path&order=asc&honorSelectedPaths=0&issueId=35441642

peter-gribanov commented 3 years ago

This can conflict with the existing method from the Doctrine and can cause problems when updating the Doctrine. It would be better not to declare this method.