search

Happyr / message-serializer

Serialize messages for transport over the wire
MIT License
77 stars 12 forks source link

Allow PHP 8 #43

Closed ddeboer closed 3 years ago

ddeboer commented 3 years ago

All green except PHPStan, which (unrelated to PHP 8) fails with:

Else branch is unreachable because ternary operator condition is always true.

on https://github.com/Happyr/message-serializer/blob/master/src/Transformer/Transformer.php#L49.

@Nyholm Any idea what’s up with that?

Nyholm commented 3 years ago

Im not sure why. But let's fix that later.

Thank you for this PR!