Haptic-Apps / Slide

Slide is an open-source, ad-free Reddit browser for Android.
https://reddit.com/r/slideforreddit
GNU General Public License v3.0
1.78k stars 345 forks source link

v.redd.it videos are not Displaying Properly #3396

Open MetalNeo opened 3 years ago

MetalNeo commented 3 years ago

Some v.redd.it videos are not playing video. The audio plays, but the video stays black.

Example

Slide version: 6.7.1 Android version: 11

newhinton commented 2 years ago

This seems to be an issue with the exoplayer.

Using the demo application with those entries yields the same result:

      {
        "name": "reddit",
        "uri": "https://v.redd.it/0n1otu272k971/DASH_720.mp4"
      },
      {
        "name": "reddit2",
        "uri": "https://v.redd.it/buksivkk5q081/DASH_1080.mp4"
      }
newhinton commented 2 years ago

As stated in the linked issue in exoplayer, this will not be fixed in exoplayer. So to fix this issue, slide would need to supply it's own decoder for dolby-vision content.

@ccrama Is it reasonable to add a converter infront of dolby-vision content?

Alexendoo commented 2 years ago

This is something reddit really needs to fix, chrome can't even play these videos properly. dolby vision is a proprietary codec so shipping an implementation of it may not be possible