double-calling of component field initialization procs 🐛

Describe the bug 🐛 Sometimes component fields initialize twice..and sometimes they don't. This matters in cases where components change external state on creation.

To Reproduce 👨‍🔬


var index = 0

proc newIndex(): int =
  result = index
  index += 1

type refIndex = ref object
  value*: int

var rindex = refIndex(value:0)
var sindex = refIndex(value:0)
var tindex = refIndex(value:0)
var uindex = refIndex(value:0)

proc nextIndex(r: refIndex): int =
  result = r.value
  r.value += 1

proc newIndexByRef(): int =
  result = rindex.value
  rindex.value += 1

component Index:
  index: int = newIndex()
  Rindex: int = newIndexByRef()
  myRefIndex: refIndex = sindex
  Sindex: int = myRefIndex.nextIndex()
  html:
    tDiv: "my index is {self.index.val}"
    tDiv(style="color:purple"): "my refIndex is {self.Rindex.val}"
    tDiv(style="color:orange"): "my internal refIndex is {self.Sindex.val}"
    tDiv(style="color:green"): "my refIndex from the main body is {uindex.nextIndex()}"

appRoutes("ROOT"):
  "/":
    Index
    Index
    Index
    for i in 1..3:
      tDiv(style="color:green"):
        "call from route: {tindex.nextIndex()}"

Each successive call of each type should count 0,1,2... but that is not what we see.

Interestingly the double-calling disappears when it is based on a reference stored in another field.

noted on happyx@#head: https://github.com/HapticX/happyx/commit/1fbc1a93f750edc6a03daafc855658f316c25db5 maybe connected with resolution to #237?

HapticX / happyx

double-calling of component field initialization procs 🐛 #244