search

Harald67 / c150

Flightgear Cessna 150
4 stars 1 forks source link

Add fuel valve #51

Closed Harald67 closed 7 years ago

Harald67 commented 7 years ago

that disappeared in the remake of the c150.

image

This is needed for the checklist.

gilbertohasnofb commented 7 years ago

@Harald67 do you need a texture for this?

Harald67 commented 7 years ago

Yes, the old one was really small. c150-int2.png : image

gilbertohasnofb commented 7 years ago

@Harald67 Ok, so I will work on it, bur there is not much space left on c150-int2.png, so what if I add this texture to the c150-obj.png?

Harald67 commented 7 years ago

yes, good idea.

gilbertohasnofb commented 7 years ago

Done, see:

fuel selector

I based it on the following photograph:

I added it to the -obj.png file and remove the older one from -int2.png to make space there. The modifications are already pushed in the new branch bug-51.

Harald67 commented 7 years ago

Thank you !

gilbertohasnofb commented 7 years ago

My pleasure :wink:

Harald67 commented 7 years ago

The valve still need to be animated. I can't find the fuel switch property atm...

gilbertohasnofb commented 7 years ago

In the c172p we use /consumables/fuel/tank[0]/selected, which is a boolean.

gilbertohasnofb commented 7 years ago

Also, I have the impression the plaque with the fuel selector texture I created is too large, are you sure about its size Harald?

Harald67 commented 7 years ago

Now that you ask, I really have no clue of its real size and I could not find any photo that could help. How small should it be ? half size ? 3/4 of the current size ?

gilbertohasnofb commented 7 years ago

I also do not know exactly the size, but looking at the photograph in this https://github.com/Harald67/c150/issues/51#issuecomment-239862302 I would say it has to be around half of the current size, maybe a bit larger. See how the plaque is slightly smaller than the handle itself, so we can use that as a reference.

gilbertohasnofb commented 7 years ago

@Harald67 thanks for the fix, it looks much better. But I think in the OFF position the handle should be pointing down, not up.

Harald67 commented 7 years ago

Another photo for reference. image

gilbertohasnofb commented 7 years ago

That's a great picture! So I think the current size we have now is fine, what do you think?

Harald67 commented 7 years ago

yes it should be good. Since I'm doing a bit of modeling in the cabin atm I've also moved the floor step a bit backward.

Harald67 commented 7 years ago

Isn't the handle a bit large now ? Also note that there is a strange effect with the tooltip, it does not update correctly when changing the position of the selector.

gilbertohasnofb commented 7 years ago

Isn't the handle a bit large now ?

I don't know, it looks fine to me.

Also note that there is a strange effect with the tooltip, it does not update correctly when changing the position of the selector.

I can reproduce it here, but I don't know what is causing it. But I wanted to ask you, are you sure you can use boolean expressions such as var fuelOn = getprop("consumables/fuel/tank[0]/selected") or getprop("consumables/fuel/tank[1]/selected"); when declaring a variable? I never seen that before. Also, we could simplify those scripts a bit since the c150 has only one single position for BOTH tanks or NEITHER tank being selected, so all these logical ors are not very necessary (i.e. tank[0] and tank[1] are always both selected or neither selected)

Harald67 commented 7 years ago

Also, we could simplify those scripts a bit since the c150 has only one single position for BOTH tanks or NEITHER tank being selected

The problem is that there is two tanks in the fuel & payload dialog and each one can be selected individually there.