possible solution for bug-51

Harald67 / c150

Flightgear Cessna 150

4 stars 1 forks source link

possible solution for bug-51 #61

Closed gilbertohasnofb closed 7 years ago

gilbertohasnofb commented 7 years ago

Closes #51

@Harald67 this is a possible solution to the bug 51:

it solves the problem of the hovering message with the fuel valve
it creates a single property that makes either BOTH or NEITHER tank selected (just like the real plane)
it does not allow the user to select a single tank via the fuel dialog, since this is unrealistic (there is no such switch)

Harald67 commented 7 years ago

It's ok for me ; we can no more deselect the fuel tank from the standard dialog but I don't think we can do better until we have our own fuel dialog.

Thanks !

gilbertohasnofb commented 7 years ago

Yeah, unfortunately I don't know any other possible solution. I suspect we could create our own version of the fuel and payload dialog and make those checkboxes direct to this new property I created, but I don't know then if it would be possible for FG to redirect the menu link to our dialog version.

Harald67 commented 7 years ago

This is probably not the difficult part, the menu does

        <item>
            <name>fuel-and-payload</name>
            <binding>
                <command>nasal</command>
                <script>gui.showWeightDialog()</script>
            </binding>
        </item>

And gui.showWeightDialog() can be overridden in our Nasal code like any other predefined function.

Since I want to add canvas based dialog for the next release that dialog could be a good candidate.

gilbertohasnofb commented 7 years ago

Oh, I see, so that should be easy to fix then. I think we could then make a local copy of the fuel and payload and direct all those checkboxes to the new property I created consumables/fuel/both-tanks-selected