search

Harald67 / c150

Flightgear Cessna 150
4 stars 1 forks source link

Flaps should not work without battery #62

Open ghost opened 7 years ago

ghost commented 7 years ago

At the moment the flaps are working independent of the electrical system, but as these are electrical flaps, shouldn't they depend on the battery/alternator switched on?

gilbertohasnofb commented 7 years ago

No need for the question tag, the flaps are electrical and shouldn't work when the master is off.

ghost commented 7 years ago

Okay, that was the question I had, now I can try to do it myself..

ghost commented 7 years ago

In the last commit the property /controls/flight/flaps-serviceable will be set to false if no power is there, but flaps are still working, do you know how to change that @gilbertohasnofb @Harald67 ?

gilbertohasnofb commented 7 years ago

I don't like using the serviceable property for that, I think this should be done via the electrical system. Maybe @Harald67 is the guy to take a look at this.

Also, here is another thing with this type of flap lever: as far as I know, you should hold the lever up or down to bring the flaps up or down while using the scale on the left side of the cockpit to see the position of the flap. That is, there are no notches as in the c172p, so it's up to the pilot to release the lever to the neutral position at the correct time. If that's the case, then we could emulate this behaviour when using the mouse, what do you think @Harald67 ?

ghost commented 7 years ago

Yep, IIRC you're right, so the complete flaps lever animation needs to be reversed.

Harald67 commented 7 years ago

Yes we can do that. So instead of going from one position to another the animation code should just increment the position a bit. The tooltip should already work correctly.

I also agree that serviceable should not be used for that.

gilbertohasnofb commented 7 years ago

@Harald67 :+1: