search

HaraldKi / monqjfa

NFA and DFA implementation in Java
http://pifpafpuf.de/Monq.jfa/
GNU General Public License v2.0
14 stars 11 forks source link

DfaRun extends CharSource but pushBack does not work #2

Open HaraldKi opened 8 years ago

HaraldKi commented 8 years ago

Instead there are the unskip() methods. This is confusing.

Either get pushBack to work correctly or make sure it does not appear in the public interface.

HaraldKi commented 8 years ago

Not completely nonsensical. unskip() shoves back characters into the input of the DfaRun, while the inherited pushback() pushes character back into the output, i.e. the can be read() without being filtered.

Need at least a bit of documentation to remind the user of this detail.