search

HarborYuan / ovsam

[ECCV 2024] The official code of paper "Open-Vocabulary SAM".
https://www.mmlab-ntu.com/project/ovsam
Other
914 stars 27 forks source link

Label token is useless? #10

Closed jameslahm closed 8 months ago

jameslahm commented 8 months ago

Thank you for your great work! I found the label token in OVSAMHead seems to be useless because the cls_embed is multiplied with 0 like below. https://github.com/HarborYuan/ovsam/blob/62c8ab5ca6e4b3ea75a0ea8a0a806f0a19da9cc6/seg/models/heads/ovsam_head.py#L219

Do I understand right? Thank you!

HarborYuan commented 8 months ago

You are correct.

Please refer to the CLIP2SAM section in the paper. The design with Q_label corresponds to the "straightforward" approach.