search

Harborn-digital / cookie-consent-bundle

Symfony bundle to append Cookie Consent to your website to comply to AVG/GDPR for cookies.
MIT License
19 stars 18 forks source link

Shouldn't the form action be configurable? #59

Closed gonzalovilaseca closed 2 years ago

gonzalovilaseca commented 4 years ago

If a user goes to a specific page for the first time, the consent form will POST to that url, so in order to work all routes have to accept POST. Wouldn't it be better to have a configurable path for the form action? And have the save action point to a controller action instead of the listener building the form on every request?

matthijsch commented 4 years ago

That's indeed a valid issue I haven't thought of. I'll make these changes when I get the chance

gonzalovilaseca commented 4 years ago

I have cloned your repo and made the changes already as I needed them for my app, I jusst need to clean up and do a PR if that's ok.

matthijsch commented 4 years ago

That would be great, thanks!

ttcremers commented 4 years ago

Hi All, Any progress on the PR? Thanks

danakil commented 3 years ago

Hello, and thank you for your work ! Just had the same problem. I'd love an update on this issue :)

phtmgt commented 3 years ago

Same here.

simonhard commented 2 years ago

I did a solution over here: https://github.com/ConnectHolland/cookie-consent-bundle/pull/106/files

matthijsch commented 2 years ago

PR has been merged, thanks for the contribution!