HarbourMasters / 2ship2harkinian

Creative Commons Zero v1.0 Universal
765 stars 64 forks source link

Fix rumble lasting too long #736

Closed Archez closed 2 months ago

Archez commented 2 months ago

This fix for rumble duration is modeled after the one in SoH https://github.com/HarbourMasters/Shipwright/pull/2419 with a slight improvement to account for when the game is in 30fps or 60fps update rates.

Notably, this has the draw back of quick/weak rumble requests getting skipped by being less than 3 VI (charged sword attack rumble).

As mentioned on the SoH side, a proper solution for OS Threads would be more ideal, but this at least gets 2Ship experience in line with SoH.

Build Artifacts