HarbourMasters / 2ship2harkinian

Creative Commons Zero v1.0 Universal
765 stars 64 forks source link

`Incorrect ROM file - No valid ROMs were provided` (Verified Checksums) #751

Open ThisNekoGuy opened 2 months ago

ThisNekoGuy commented 2 months ago

Description of the bug:

Can you reproduce? If so please list the steps:

  1. In my case, I compiled from source then had the following in a folder: 2s2h.sh 2s2h.elf gamecontrollerdb.txt 2s2hIcon.png
  2. cd to the folder containing these items via terminal (in my case, extracted from a zip archive)
  3. Run ./2s2h.sh
  4. Encounter the strange behavior (on a first attempt, it may look fine but you'll notice there's only a mods folder; subsequent attempts show the described behavior below)

Expected behavior:

When running the Linux launch script, the Zenity pop-up claims that no valid rom was found and yet also attempts to generate an OTR in a seperate window regardless before eventually closing itself. Additionally, only the mods folder ever seems to get created and I never find the temp directory that's supposed to be made in /tmp despite having user permissions to do so.

Screenshots or videos:

screenshot

System Information:

Additional Information:

Shell Output:

cp: cannot stat '/tmp/assets-WRXTD/mm.o2r': No such file or directory
Warning: --window-icon is deprecated and will be removed in a future version of zenity; Treating as --icon.
Warning: --icon-name is deprecated and will be removed in a future version of zenity; Treating as --icon.

(zenity:19440): Gtk-WARNING **: 00:22:00.845: Unknown key gtk-modules in /home/neko/.config/gtk-4.0/settings.ini

(zenity:19444): Gtk-WARNING **: 00:22:00.847: Unknown key gtk-modules in /home/neko/.config/gtk-4.0/settings.ini

(zenity:19440): Adwaita-WARNING **: 00:22:00.909: Using GtkSettings:gtk-application-prefer-dark-theme with libadwaita is unsupported. Please use AdwStyleManager:color-scheme instead.

(zenity:19444): Adwaita-WARNING **: 00:22:00.910: Using GtkSettings:gtk-application-prefer-dark-theme with libadwaita is unsupported. Please use AdwStyleManager:color-scheme instead.
Archez commented 1 month ago

Hi, are you still encountering this problem?

I think in this case what you are missing is the compiled ZAPD.out binary and the assets folder that contains all the xml files for extraction. Without this, the 2s2h.sh script won't be able to generate an mm.o2r properly. The script is provided as-is and assumes that it is running from the appimage. You can refer to our CMake and CPack steps to see how we are bundling the final appimage.