HarbourMasters / 2ship2harkinian

Creative Commons Zero v1.0 Universal
835 stars 69 forks source link

[Enhancement] Allow equipping Great Fairy Sword to the B Button #760

Open balloondude2 opened 2 months ago

balloondude2 commented 2 months ago

This PR adds an enhancement that allows you to equip/unequip the Great Fairy Sword to "B". This is done by pressing "A" on the Great Fairy Sword in the pause menu. Wearing the Fierce Deity, Bremen, Kamaro, or Blast masks will unequip the Great Fairy Sword from B.

Adds new hook: OnItemStolen. This hook executes when the bird near Milk Road steals an item from you and passes the stolen item as an argument.

~Leaving as a draft for now because I would like input on the following items:~

  1. ~How should equipping GFS to a C button behave when the enhancement is on? Should the C button use GFS normally, toggle it's state on B, or should we prevent GFS from being set to C?~
  2. ~Having the GFS on B currently overrides the special B button actions of the Bremen and Blast masks. Is this acceptable?~
  3. Any opinions on what sound effects are used when equipping/unequipping from B?

Build Artifacts

balloondude2 commented 2 months ago

I think this is in a good enough state to set as ready for review now.