search

HarbourMasters / 2ship2harkinian

Creative Commons Zero v1.0 Universal
835 stars 69 forks source link

[Enhancement] Disable Takkuri Steal #776

Closed mckinlee closed 1 month ago

mckinlee commented 1 month ago

It just simply returns false in func_80C10B0C if the the checkbox is checked. Nothing fancy.

Put it in Time Savers section for now, not sure where this fits best.

Build Artifacts

mckinlee commented 1 month ago

I think a new "difficulty options" section similar to SoH's might make sense to house this?

Additionally we should use the VB pattern to prevent this behavior. I would suggest adding a new VB enum for GI_VB_THIEF_BIRD_STEAL, and within thiefbird.c around line 588 wrap the (Rand_ZeroOne() < 0.5f) with a GameInteractor_Should. This will allow us to rely on the vanilla condition (50% randomness) and allow us to override it when we want

Thanks for the feedback. I've made those changes. :)