HarbourMasters / 2ship2harkinian

Creative Commons Zero v1.0 Universal
792 stars 67 forks source link

[Vanilla Bug] Ikana Canyon Fairy Fountain color doesn't match its Stray Fairy color. #787

Closed SuperBro64 closed 2 weeks ago

SuperBro64 commented 2 weeks ago

In the Japanese and US versions of vanilla MM, the Great Fairy's Fountain in Ikana Canyon has a green background, which doesn't match the yellow color of that fountain's Stray Fairies. According to The Cutting Room Floor (https://tcrf.net/The_Legend_of_Zelda:_Majora%27s_Mask/Program_Revision_Differences#Ikana_Fairy_Fountain_Coloring), this is due to "the environment not being set properly".

This bug was later fixed in the EU version so that the fountain color is yellow. Thus, since 2Ship currently only accepts the US versions of the game, perhaps an bug fix enhancement could be made to fix the color of the fountain?

Screenshot from TCRF showing the differences in the Ikana fountain color between versions: image

Screenshot showing how the Ikana fountain currently looks in 2Ship: image

garrettjoecox commented 2 weeks ago

Interestingly, when you debug warp to that fairy fountain it has the correct color, if you leave and re-enter it has the broken color

Screenshot 2024-10-02 at 1 58 19 PM
Archez commented 2 weeks ago

Looks like having Stone Tower temple cleared or not is what causes this. If you load Ikana with the complete flag set, the sky in Ikana is "clear", then walking into the fountain will be yellow. But if the sky is "gloomy", and the clear flag is unset, then it's green.

If the flag is not set, then the "previous" weather mode is retained

    if (gSaveContext.retainWeatherMode || (gSaveContext.respawnFlag != 0)) {
        switch ((u32)gWeatherMode) {
            case WEATHER_MODE_2:
                if (!CHECK_WEEKEVENTREG(WEEKEVENTREG_CLEARED_STONE_TOWER_TEMPLE)) {
garrettjoecox commented 2 weeks ago

Looks like having Stone Tower temple cleared or not is what causes this. If you load Ikana with the complete flag set, the sky in Ikana is "clear", then walking into the fountain will be yellow. But if the sky is "gloomy", and the clear flag is unset, then it's green.

Glad we came to the same conclusion 😆 I imagine they have a more "correct" fix in the EU version but I PR'd a bandaid

Archez commented 2 weeks ago

Fix merged 👍