HarbourMasters / 2ship2harkinian

Creative Commons Zero v1.0 Universal
885 stars 71 forks source link

Fix bug with two-handed sword magic and Kamaro's Mask dance #819

Closed Eblo closed 2 weeks ago

Eblo commented 2 weeks ago

The two-handed sword magic enhancement introduced a bug with Kamaro's Mask. I overzealously applied the hook to the B button held check that applies to the dance. The enhancement changes logic so that it checks the button of the currently assigned item, rather than always B, for a held press. When using Kamaro's Mask to dance, there is no held item to check for a button press, so Link would cut out of the animation a couple frames into it if this enhancement was enabled.

This PR removes the erroneous hook point.

Build Artifacts