search

Hardhat-Enterprises / Deakin-Detonator-Toolkit

Deakin Detonator Toolkit redesign using Tauri, React and Mantine.
15 stars 24 forks source link

503 feature request AMAP tool #631

Closed Harshpatel24197 closed 5 months ago

Harshpatel24197 commented 6 months ago

Implemented code for Amap with basic scan feature of IP address with TCP, UDP and other networking features.

bradleybogg commented 5 months ago

The PR title should be reflective of the issue it connects to. Please see other PRs for reference. In future it is best to create it from the github issue and this will be completed for you.

bradleybogg commented 5 months ago

Please review how to create a PR https://betterprogramming.pub/how-to-make-a-perfect-pull-request-3578fb4c112

bradleybogg commented 5 months ago

You also need to make sure that each commit is a bite size. It is unacceptable to commit such large changes in a single commit. Make sure that your next PR reflects this to show continued learning.

michaeljpigott commented 5 months ago

@zkkok This one is ready for application testing.

michaeljpigott commented 5 months ago

Hold off on application testing @zkkok. I found an issue that needs addressing.

zkkok commented 5 months ago

Hi @Harshpatel24197 , Please resolve the conflicts before application testing