Hardhat-Enterprises / Deakin-Detonator-Toolkit

Deakin Detonator Toolkit redesign using Tauri, React and Mantine.
14 stars 25 forks source link

407 feature request fcrackzip tools #634

Closed namanbkshi closed 3 months ago

namanbkshi commented 4 months ago

This Pull request is generated with the intentions of solving two issues namely:

  1. 407 feature request fcrackzip tools #634 and
  2. [Bug Fix (Baseline)]: Fcrackzip #586

For the feature request:

1.Set 'Show cracked password' to be enabled by default: Initialized the checkedUnzip state with true, so the checkbox for displaying the cracked password is enabled by default.

  1. Ensure Charset List remains active: Removed logic that disabled Charset List options based on other checkbox states. Now, all Charset List options remain active and selectable regardless of other option states, ensuring consistent usability.

3.Adjusted the output behavior to always display the cracked password, especially when using the Dictionary Attack Method.

Improved the baseline by improving the comments & docstrings along with implementing the following changes:

Certainly! Here's a breakdown of the changes in bullet points:

bradleybogg commented 4 months ago

No update on previous request.

namanbkshi commented 4 months ago

No update on previous request.

Hello Bradley ! This pull request was made for the implementation of feature request but in the weekly meeting I was told to implement the baseline as well in the same request.

So perhaps you want me to create another pull request ?

namanbkshi commented 4 months ago

Hi. I am done with the changes. Thanks in advance.

namanbkshi commented 3 months ago

Hey Michael, I have implemented the changes in the new commit. Thanks for your help.