search

Hardhat-Enterprises / Deakin-Detonator-Toolkit

Deakin Detonator Toolkit redesign using Tauri, React and Mantine.
14 stars 25 forks source link

296 cancel operation ddt wide rollout 1 #645

Closed anjojoseph closed 4 months ago

anjojoseph commented 4 months ago

Hi Brad/Team, I have implemented cancel operation for Netcat tool. Run npx prettier command. Kindly verify and merge. Thank you

anjojoseph commented 4 months ago

Hi Brad, I worked on Hardhat-Enterprises/Deakin-Detonator-Toolkit/tree/296-cancel-operation-ddt-wide-rollout-1/src/components/Netcat /Netcat.tsx , file to implement cancel operation, as per of Feature Request: Cancel Operation (https://trello.com/c/rQLOilvH) Updating all tool’s that use CommandHelper.runCommand() to use CommandHelper.runCommandGetPidAndOutput() and updating associated logic to enable a tool’s execution to be cancelled by the user.

I believe the conflict happened as the same file src/components/Netcat/Netcat.tsx has been modified on the main barnch after New branch for Netcat improvements and formatted #530 has been approved. Currently I work to resolve these conflicts and implement cancel operation. Thank you

anjojoseph commented 4 months ago

Awaiting Bas to merge his branch to main as he works on Netcat.tsx I will start to resolve these conflicts after this.

anjojoseph commented 4 months ago

Latest netcat tool uses CommandHelper.runCommandGetPidAndOutput() function hence stopped working on netcat tool. for cancel operation