Hardhat-Enterprises / Deakin-Detonator-Toolkit

Deakin Detonator Toolkit redesign using Tauri, React and Mantine.
11 stars 19 forks source link

625 feature request handleprocessdata improvement #655

Closed michaeljpigott closed 2 months ago

michaeljpigott commented 3 months ago

Pull request description

This pull request fixes issue #625 whereby DDT cannot handle terminal output that is using ANSI colour stylings.

Changes made

The fix was to simple add a line of code in CommandHelper.ts that uses regex in the replace method to look for any ANSI colour stylings in the data and replace them with an empty string.

michaeljpigott commented 3 months ago

Hi, I adjusted the regex in CommandHelper.ts so it strips out the VT100 escape codes that were appearing in the Aircrack-ng output. I tested on Aircrack-ng, Arjun and WPScan and they weren't showing any escape characters.

michaeljpigott commented 2 months ago

@zkkok can you please do some application testing on this pull request? Relevant tools that have escaped characters are Aircrack-ng, WhatWeb, Arjun and WPScan.

michaeljpigott commented 2 months ago

Thank you @zkkok for testing.