606 bug fix baseline shodan

Hardhat-Enterprises / Deakin-Detonator-Toolkit

Deakin Detonator Toolkit redesign using Tauri, React and Mantine.

11 stars 19 forks source link

606 bug fix baseline shodan #681

Closed jonschlack closed 2 months ago

jonschlack commented 2 months ago

606 bug fix baseline. Thank you.

Some of the changes:

Removed unused imports Added new imports Renamed FormValues to FormValuesType Added Docstrings to various functions and components that did not have them Added code comments to various components Removed handleCancel and replaced with [{LoadingOverlayAndCancelButton Added Rendercomponent and loadingModal &Added useEffect function Ran Prettier to fix style issues

michaeljpigott commented 2 months ago

Hi @jonschlack

Can you please use yarn run style in your terminal and fix any problems with npx prettier --write ?

Kind regards

Michael

jonschlack commented 2 months ago

Hi @jonschlack

This is looking good. You just need to investigate the InstallationModal because I am finding that it is popping up briefly every time I enter the tool in DDT.

Kind regards

Michael

Looked into InstallationModal in Shodan component and changed it to true in component. Appears to have resolved issue of popup every time while entering tool. Please check updated code to see if it's resolved. Thank you!