search

Hardhat-Enterprises / Deakin-Detonator-Toolkit

Deakin Detonator Toolkit redesign using Tauri, React and Mantine.
11 stars 19 forks source link

605-bug-fix-baseline-sherlock #683

Closed MattMina04 closed 1 month ago

MattMina04 commented 2 months ago

605-bug-fix-baseline-sherlock

michaeljpigott commented 2 months ago

Hi @MattMina04, I cannot see any changes here. Can you please check and push your changes to sherlock.tsx to the branch?

Kind regards

Michael

MattMina04 commented 2 months ago

Oh so sorry Michael, i just pushed my changes i think. check again and let me know please

From: michaeljpigott @.> Sent: Saturday, 11 May 2024 4:42 PM To: Hardhat-Enterprises/Deakin-Detonator-Toolkit @.> Cc: MattMina04 @.>; Mention @.> Subject: Re: [Hardhat-Enterprises/Deakin-Detonator-Toolkit] 605-bug-fix-baseline-sherlock (PR #683)

Hi @MattMina04https://github.com/MattMina04, I cannot see any changes here. Can you please check and push your changes to sherlock.tsx to the branch?

Kind regards

Michael

— Reply to this email directly, view it on GitHubhttps://github.com/Hardhat-Enterprises/Deakin-Detonator-Toolkit/pull/683#issuecomment-2105597502, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMJ32JLBWIOFJWY66MSWKSDZBW4XBAVCNFSM6AAAAABHQPQQT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGU4TONJQGI. You are receiving this because you were mentioned.Message ID: @.***>

michaeljpigott commented 2 months ago

Hi @MattMina04, I still cannot see any changes. Make sure you add your changes to your local branch, commit them and push them to this branch: 605-bug-fix-baseline-sherlock

Good luck.

Michael

MattMina04 commented 2 months ago

Hey i think i did it. can you check for me when you can please. Thanks

From: michaeljpigott @.> Sent: Monday, 13 May 2024 8:46 AM To: Hardhat-Enterprises/Deakin-Detonator-Toolkit @.> Cc: MattMina04 @.>; Mention @.> Subject: Re: [Hardhat-Enterprises/Deakin-Detonator-Toolkit] 605-bug-fix-baseline-sherlock (PR #683)

Hi @MattMina04https://github.com/MattMina04, I still cannot see any changes. Make sure you add your changes to your local branch, commit them and push them to this branch: 605-bug-fix-baseline-sherlock

Good luck.

Michael

— Reply to this email directly, view it on GitHubhttps://github.com/Hardhat-Enterprises/Deakin-Detonator-Toolkit/pull/683#issuecomment-2106398530, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMJ32JIFU252PHFVM3VJ2RTZB7WM7AVCNFSM6AAAAABHQPQQT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGM4TQNJTGA. You are receiving this because you were mentioned.Message ID: @.***>

michaeljpigott commented 2 months ago

Hi @MattMina04, I can see the changes thank you. You need to remove the following files out of your branch. Baseline bug fixes should only affect one file, the tsx file for the tool in question.

MattMina04 commented 2 months ago

Oh sorry, just deleted them now.

From: michaeljpigott @.> Sent: Saturday, 18 May 2024 3:19 PM To: Hardhat-Enterprises/Deakin-Detonator-Toolkit @.> Cc: MattMina04 @.>; Mention @.> Subject: Re: [Hardhat-Enterprises/Deakin-Detonator-Toolkit] 605-bug-fix-baseline-sherlock (PR #683)

Hi @MattMina04https://github.com/MattMina04, I can see the changes thank you. You need to remove the following files out of your branch. Baseline bug fixes should only affect one file, the tsx file for the tool in question.

— Reply to this email directly, view it on GitHubhttps://github.com/Hardhat-Enterprises/Deakin-Detonator-Toolkit/pull/683#issuecomment-2118646311, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMJ32JJZOIEPKYO2N3LV5W3ZC3QG7AVCNFSM6AAAAABHQPQQT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYGY2DMMZRGE. You are receiving this because you were mentioned.Message ID: @.***>