search

Hardhat-Enterprises / Deakin-Detonator-Toolkit

Deakin Detonator Toolkit redesign using Tauri, React and Mantine.
15 stars 23 forks source link

604 bug #839

Closed shivang2311 closed 1 month ago

shivang2311 commented 2 months ago

made changes as told @Oliver2049 in previous branch, which is 604-bug-fix. i created new one because in that one i got some unexpected errors. So can you please review this one? Thanks!!

shivang2311 commented 2 months ago

In the SearchSploit task, I focused on fixing a baseline bug by updating the component according to a predefined checklist. This included standardizing the code, removing unnecessary imports, and ensuring proper use of React hooks and components like LoadingOverlayAndCancelButtonPkexec. I also followed the project's style guide to ensure consistency.

Oliver2049 commented 2 months ago

In the SearchSploit task, I focused on fixing a baseline bug by updating the component according to a predefined checklist. This included standardizing the code, removing unnecessary imports, and ensuring proper use of React hooks and components like LoadingOverlayAndCancelButtonPkexec. I also followed the project's style guide to ensure consistency.

Thanks, @shivang2311 I will check and provide feedback to you as soon as possible. Thanks. Regards, Oliver

Oliver2049 commented 1 month ago

Hi @shivang2311 , Well sadly for this one, you will have to remove the py file as well before I can review the pull request. Regards, Oliver