CK-Editor will be invisible when installing hardocs without an internet connection

Hardocs / desktop-app

Hardocs desktop app presenting current docs editing functionalities.

GNU General Public License v2.0

3 stars 2 forks source link

CK-Editor will be invisible when installing hardocs without an internet connection #59

Closed jurra closed 3 years ago

jurra commented 3 years ago

Current behavior

When the app is executed offline the ckeditor will not show in the app, instead it will show this:

As it can be seen the editor doesnt show properly

Desired behavior

When the app is opened offline it should look like the picture below.

The editor should work offline as well as it works now when connected.

jurra commented 3 years ago

This is happening because of a call being made by the MathType module,

Hey 🥇 @DNature it would be great if you could rebuild the editor without this particular module, I am currently working on hotfix/npm-ckeditor-module you can update the packagejson and let me know when that is ready, I can then integrate it back again and review it.

Thanks in advance 😄

DNature commented 3 years ago

Okay. I will do that first thing tomorrow

DNature commented 3 years ago

[x] publish new hardocs-ck-editor to npm
[x] Install the latest version of hardocs-editor in the desktop app
[x] Update desktop-app version
[x] Test out the workflow build
[x] draft a new release
[x] publish the new release

jurra commented 3 years ago

This is solved, it implited sacrifycing the Math module. We need to keep an eye on that module development, because this is a pending issue I saw on their repository.