HardstuckGuild / GW2-Tooltips.js

Tooltips.js frontend
1 stars 1 forks source link

Attribute Rounding #32

Closed mightyteapot closed 8 months ago

mightyteapot commented 9 months ago

Numbers pertaining to builds such as attribute values should probably be rounded, attributes are rounded in the game as there is no concept of 0.7 power etc. image

SaculRennorb commented 9 months ago

If we round the intermediates the final sum wont match and that would certainly be awkward aswell. Before i go ahead and try to figure it out myself, do we know if the game actually rounds each value or keeps track of the fractions internally? Both could reasonably be true as the game never shows you the individual stat sources like this.

mightyteapot commented 8 months ago

I checked this, rounded values are used for all purposes in game, the values currently displayed by ttjs are therefore slightly incorrect.

I replicated this build in game exactly: https://beta.hardstuck.gg/gw2/builds/necromancer/boonstrip-scourge/

In game: image

In ttjs: image

mightyteapot commented 8 months ago

(Jade bot is accounting for extra vitality) (Armor reinforce is also increasing hp and armor by 5%)

SaculRennorb commented 8 months ago

We are getting the correct number now, but that means the game doesn't track the sharpening stone, as we also don't do that right now.

grafik

mightyteapot commented 8 months ago

Looks like stone was missing in my screenshot, with stone the power value is 2692

SaculRennorb commented 8 months ago

Alright, then it's no question about how we should handle this. Its just #72 #71