search

HardstuckGuild / GW2-Tooltips.js

Tooltips.js frontend
1 stars 1 forks source link

Show All Glyph Versions #40

Closed mightyteapot closed 9 months ago

mightyteapot commented 1 year ago

Glyphs are weird, would be nice to show all versions of a glyph instead of the 'neutral' version. I.e. show tooltip for normal and CA version for druid glyphs and fire,water,air,earth versions for elementalist and then cycle through them.

Good examples: Druid: https://beta.hardstuck.gg/?post_type=gw2_builds&p=13459 Elementalist: https://beta.hardstuck.gg/gw2/builds/elementalist/support-tempest/

SaculRennorb commented 1 year ago

I'll have to look into those specifically, but that might be difficult without breaking some other things that rely on only displaying skills in the correct profession state.

also related to #12 and #17

SaculRennorb commented 1 year ago

Ah, I remember now: We originally had this 'feature', showing all states at once, but it really only is usefull for the summary section of the build. For the actual written guide it is extremely questionable to show al variations of the skills and it becomes confusing rather quickly, so i added a check for the profession state I was talking about.

Another point to consider is that adding this would probably add a bunch of hard coding as we don't want this behavior with all skills, but only a select few.

Maybe I can figure out how to reliably identify Glyphs specifically as it seems to mostly be an issue with exactly those skills.

SaculRennorb commented 1 year ago

Should work with the next api build.

mightyteapot commented 1 year ago

What is the currently functionality of this?

SaculRennorb commented 1 year ago

I didn't rebuild update the api until just now, it should now be working but please double check that its working:

Glyphs should be rendered in the following way: grafik

For elementalist glyphs i added additional logic to try and keep the atunement versions in groups one after the other: grafik

SaculRennorb commented 12 months ago

Apparently this doesn't work properly for some glyphs:

grafik

SaculRennorb commented 11 months ago

The reason this doesn't work for this specific glyph right now is the fact that this specific glyph doesn't have the glyph category.

Interestingly it does have that category in the official api.

SaculRennorb commented 11 months ago

Oh, and for some reason the glyph palette for it has the attuned versions twice, with ever so slight differences between them (mostly the icon not being tinted) but the exact same preconditions.

SaculRennorb commented 9 months ago

The other skills in the palette are underwater skills. they aren't tinted for whatever reason. they probably just forgot. Ironically the land skills may also be used underwater, but will never be selected by the palette to do so.