Conditional Defiance Damage Gets Merged In Total

[mightyteapot]

Might be extremely difficult to resolve. Dagger 3 daze has two durations based on whether target is casting or not, both currently get merged into the total defiance break. Solution might be to not show a total for skills like this if they can be detected. https://beta.hardstuck.gg/gw2/builds/warrior/defense-spellbreaker/

[SaculRennorb]

Yea, this might be extremely difficult. Detecting it should be possible, we could try something like

if skill.description.contains('if' || 'against')
  && fact.text.contains('vs' || 'against' || 'if') {
 //great, now what ?
}

or just texting for two facts of the same defiance breaking buff following each other, one with overwritten text.

Then there is the problem of what to even do with those facts? use the uncoditional to calculate the sum? split it and display both sums ? Are there cases with more than two 'states' ?

[mightyteapot]

Safe is to just disable the total I think if we can detect accurately, bad news is I found some other somewhat worse examples and there are probably at least a few similar skills.

https://beta.hardstuck.gg/gw2/builds/mesmer/side-mirage/

Chaos storm applies random effects in sequence (daze is always first then random) Magic bullet applies different effects per target Stun->Daze->Confusion

What's interesting is that the in game tooltips are also wrong for these and have the same behavior currently displayed here.

[mightyteapot]

Bunch of really good info on this exact issue in game here: https://wiki.guildwars2.com/wiki/Defiance_Break#:~:text=Defiance%20Break%20is%20a%20property,tooltip%20with%20a%20teal%20font.

[SaculRennorb]

Ok yea - i don't see any way of detecting it on those skills specifically, might be a case of having to hard code it for those if we want to correct them.

[SaculRennorb]

Idea: use data form the wiki to correct skills? Issue would be update trigger / rate with the current api implementation, but it could be done i think.