HardstuckGuild / GW2-Tooltips.js

Tooltips.js frontend
1 stars 1 forks source link

Sleight Of Hand Steal Defiance Damage Doesn't Show #54

Closed mightyteapot closed 9 months ago

mightyteapot commented 9 months ago

image

When traited with 'Sleight of hand' stealing dazes the target for 1s, which should deal 100 defiance damage. This isn't listed on the tooltip. I think that the mechanism for this may be that control effects added to skills by traits don't get counted, can't be 100% sure though because I believe this is the only trait that does something like this in the entire game.

https://beta.hardstuck.gg/gw2/builds/thief/mercy-deadeye/

SaculRennorb commented 9 months ago

Fact conditions shouldn't affect the defiance damage counting, there seems to be another issue here. Wail of doom also works fine with the additional defiance damage from the trait. Maybe this is related with the detection we have for 'Removes ' Facts that must not be counted for the total defiance damage.

SaculRennorb commented 9 months ago

Apparently that fact doesn't have its type set to 'Daze', but just to generic 'Buff'. However the buff it uses (833) does have its type set to 'Daze', so i should be able to make a generalized version for situations like this.

SaculRennorb commented 9 months ago

Should be fixed with the next api build. I'm currently checking to see if it has some impact on random other stuff, but it seems to be fine.

SaculRennorb commented 9 months ago

Ok, there seem to be a few strange skills affected by this, but it mostly seems to be unused(?) or npc skills that have a AOE fact that for some reason is labeled as Daze:

grafik grafik

This seems acceptable to me.