search

HardstuckGuild / GW2-Tooltips.js

Tooltips.js frontend
1 stars 1 forks source link

Scourge Shroud Ability Costs Display Incorrectly #62

Closed mightyteapot closed 9 months ago

mightyteapot commented 9 months ago

Scourge abilities cost a percentage of the base hp pool unmodified by vitality (i.e. 9212) rounded to the nearest integer, currently the costs are displayed as a percentage of the total life force pool (after vitality) and is also being increased by gluttony (10% mod from soul reaping).

Additionally, life force cost abilities currently display their percentage cost with a down arrow in the upper section of the tooltip, as opposed to the actual life force cost. Life force costs are displayed as facts in game, not in the upper portion of the tooltip so current functionality is accurate in this regard, so the arrow and percentage cost could be removed as it currently appears to suggest that using the ability requires upkeep like a rev upkeep skill.

image Nefarious favor should cost 9212 0.21 = 1934.52 -> round to 1935 image Desert shroud should cost 9212 0.5 = 4606

Bonus meme, this is really really weird implementation from anet, you would expect shroud costs to be based off the base shroud pool (19212 * 0.69) instead of the base vitality pool. Functionally it's irrelevant but quite odd.

SaculRennorb commented 9 months ago

The down arrow comes from the fact that the skill has a resource cost associated. It's not the upkeep, its just the wrong icon for it - think thief initiative. FB tome skills also have a cost of 1 resource. I already thought about that a bit, and while we could just hide it it might not be the best idea. The first move is to use the proper icons for those classes. The formula has to ofc be adjusted.

SaculRennorb commented 9 months ago

Actually, let me correct that: the skills do have their upkeep set to the value. Thats a bit more questionable, and maybe we should address it in the api.