HardstuckGuild / GW2-Tooltips.js

Tooltips.js frontend
1 stars 1 forks source link

Time Marches On Shows Defiance Break #68

Closed mightyteapot closed 6 months ago

mightyteapot commented 9 months ago

Time Marches On is a chronomancer minor trait that reduces the duration of incoming cripple chill and immobilize, the tooltip currently shows a defiance break fact which shouldn't be the case as it doesn't actually apply any conditions.

image https://beta.hardstuck.gg/?post_type=gw2_builds&p=11660

mightyteapot commented 9 months ago

Danger Time also exhibits this behavior

image

SaculRennorb commented 9 months ago

We have system in place to detect facts that just talk about cc conditions, not apply them. the issue is that these facts literally just display the condition and don't override any property of the buff. for other traits or skills the fact overrides the text of the underlying buff to something like 'Removes ...', so its easy to detect.

Right now I don't have any good idea on how to detect the cases above, but its important to document them.

SaculRennorb commented 6 months ago

The heuristic has been found.