HardstuckGuild / GW2-Tooltips.js

Tooltips.js frontend
1 stars 1 forks source link

Attribute Conversion Traits Calculate Incorrectly. #71

Closed mightyteapot closed 8 months ago

mightyteapot commented 8 months ago

Some traits convert some portion of an attribute into another. Target the weak in curses converts 13% of precision into condition damage, in the linked build below this is calculated as 23.4 additional condition damage. However, this is about 10x too low as the true value should be 236.6 (1820 * 0.13). Interestingly, this isn't exactly 10x maybe some rounding/order of operations memes?

https://beta.hardstuck.gg/gw2/builds/necromancer/booster-scourge/

mightyteapot commented 8 months ago

Upon further inspection in another necromancer build with a different precision value (1180 in this case) it appears there is something else going on, looks like target the weak always grants 23.4 condition damage no matter the precision value for a build.

https://beta.hardstuck.gg/gw2/builds/necromancer/condition-reaper/

mightyteapot commented 8 months ago

Another example, 7% healing power -> concentration displays as 8.4 instead of 1675 * 0.07 = 117.25

https://beta.hardstuck.gg/gw2/builds/revenant/heal-quickness-herald-2/

SaculRennorb commented 8 months ago

This issue will be continued in #79, I've already layed out more information there.