search

HardstuckGuild / GW2-Tooltips.js

Tooltips.js frontend
1 stars 1 forks source link

Lingering Curse Strange Behaviour #73

Closed mightyteapot closed 8 months ago

mightyteapot commented 8 months ago

Lingering curse is displaying different bugs in different contexts, what is very interesting is that it doesn't appear to behave completely correctly anywhere, but all components do function correctly somewhere (omegalul)

Behavior listed here:

https://beta.hardstuck.gg/gw2/builds/necromancer/boonstrip-scourge/ <- torment base duration correctly increased, scepter 2 facts duplicated, autos are correct. https://beta.hardstuck.gg/gw2/builds/necromancer/booster-scourge/ <- torment base duration not correctly increased on scepter 3, scepter 2 and autos are correct

Also looks like the boonstrip scourge bug is linked to #57. In fact I think this now confirms that skills being split by game mode and then modified by a trait are not working correctly (breaks override logic), will make a new issue when properly documented.

SaculRennorb commented 8 months ago

In essence, this occurs when a trait overriden fact also has a gamemode override. Since we only expose a single flag for skipping the next fact, this then only skips the 'base gamemode' version of the fact, but doesn't skip the untraited version of the fact. image This requires changes to the way we do the overriding.