Torment duration increase from asparagus skewer not respected

[SaculRennorb]

This one: https://beta.hardstuck.gg/gw2/builds/necromancer/condition-scourge/ does not properly process the 15% Torment increase

I already know that the reason for this is the fact that the buff id we produce for the effect is wrong. No clue why.

[SaculRennorb]

Documenting some stuff here:

Interestingly, this is a very wired case - The asparagus skewer adds a modifier for buff # 19426, which is in fact a torment buff. Its just not the one used by for example Feast of Corruption. that skill and quite a few others use buff # 21632.

This is not uncommon, the game has several versions of other buffs aswell, with others there is one defined one used for player skills. For some reason, specifically torment has two versions that are both used by player skills. Other buffs often modify both versions, as can be seen here, but they forgot that for the mushroom skewer.

You can actually notice this in game, as the torment duration increase gets listed in your hero panel, but it doesn't actually change the displayed duration of the torment on Feast of Corruption. The actual applied torment does get increased.

This has nothing to do with gamemode splitting, as the modifiers on the buff can be gamemode dependent on their own.

The reason the increase doesn't get displayed in our stat summary is the fact that the mushroom skewer buff (# 19426) does not get requested by any skill and therefore we don't have it cached upon rendering the summary. That results in us not knowing weather or not its a boon or a condition, resulting in it not being displayed at all.

I'm not sure at what point to address this issue, but this is an ingame bug in a certain way.

[SaculRennorb]

I should also add that from looking at other skills it appears as tho the actual bug here is the buff id of the fest of curruption skill, as most other skills and evaluations use the 19426 buff, not the 21632, so if anything that's probably what should be adjusted.

edit: both ids seems to be used somewhat equally, # 21632 seems to be more common

[SaculRennorb]

I have decided to solve this heuristically and synthesize the missing mods on MAS as well as any other buff where we can detect this behavior. Might have to keep an eye on this as im not 100% sure this wont cause issues in the future.

[SaculRennorb]

Sigil of missery (PvP) / the Missery buff it gives are also affected