HardstuckGuild / GW2-Tooltips.js

Tooltips.js frontend
1 stars 1 forks source link

Display Mirage Staff Ambushes On Auto #90

Closed mightyteapot closed 8 months ago

mightyteapot commented 8 months ago

Minor detail, mirage ambush skills are shown attached to autoattack chains, this seems to work correctly for axe, but not for staff!

Staff: https://beta.hardstuck.gg/gw2/builds/mesmer/booster-mirage/ Axe (working): https://beta.hardstuck.gg/gw2/builds/mesmer/side-mirage/

SaculRennorb commented 8 months ago

Just to note: this happens because out internal checks validate that the related skills have the same specialization requirements as the main skill.

This works for axe, as for the longest time you could only wield that if you had mirage equipped, but with the change to weapon mastery this test now has to change.

The broader question is how to address this more generally, as we want to preserve the information of which spec the skills belongs to to later on present it correctly. This might need some more thinking.