Desert Shroud Always Shows Sandstorm Shroud As A Flip

[mightyteapot]

Desert shroud will always show sandstorm shroud as a flip skill in the tooltip regardless of if herald of sorrow is traited (it shouldn't do that either, ideally that trait should convert all desert shrouds into sandstorm shrouds)

https://beta.hardstuck.gg/gw2/builds/necromancer/booster-scourge/

Might be very hard to solve as scourge shroud abilties are a total clown fiesta in game iirc.

[SaculRennorb]

Ok, so the library should in fact not automatically convert all occurrences into the traited version. that was a pit i also fell into, but it must only do that for the automatically generated build section (the main overview). You do not want it to automatically convert the references in written text, as this makes it impossible to talk about the base version of the skill if you trait it.

It showing the traited version as related is however in fact a bug.

[SaculRennorb]

Ok, so as it turns out this is another edge case.. Both of the skills have the same issue.

Here is the palette for 'Manifest Sand Shroud': as you can see both the specialization and trait filters are used to check for the scourge trait. Because they did that, they have to use the buff filter for testing for the presence of 'Sand Savant', since they already used the trait filer. This is the invisible buff (# 46324) on the image above, which you can figure out from this cobweb mess here: The dark green dot is said buff.

This is something too advanced for the current system to pick up, but I don't doubt that there are more such cases.

---

They did the same thing with 'Desert Shroud':

Afaik this wouldn't technically be necessary, as necro doesn't have the profession5 skill visible on any other specialization, but i imagine they just set it up the same way as Manifest Sand Shroud just for consistency.

Check the follow up comment for clarification.

This however means that to figure out weather or not to display Sandstorm Shroud they used the 'buff' condition to test for an invisible buff that gets set by equipping the trait for it. The issue there is that this looks identical to our heuristics for detecting skillchains on specter skills, which also use an invisible buff to exactly do that; flip through a skillchain.

Right now i don't have a solution on how to differentiate these cases, but I'm sure ill figure something out. -> we do manual overriding for now

[SaculRennorb]

After fermenting this in the back of my head for quite some time I have found the reason why this is so questionable. Mantle of Sand (the scourge trait) is not actually the 'first' trait you get from unlocking scourge. you get the torch proficiency first. That means in theory you can equip scourge and not have that trait, which they have to test for. I don't know how the game even handles the profession mechanics if you don't have that trait, and since you spend a minuscule amount of time without it (if at all) I would just not have put in all that effort and just rolled into the initial trait, But I'm not the game director, what can you do.

Unfortunately the also means that I have to find a way to detect these cases, as it is fully intentional and likely affects more specializations than just necro, we just didn't notice yet.