HardstuckGuild / GW2-Tooltips.js

Tooltips.js frontend
1 stars 1 forks source link

Sometimes Items Don't Show Their Names #99

Closed mightyteapot closed 2 months ago

mightyteapot commented 8 months ago

Sometimes item's don't correctly display their names, interestingly enough when I refreshed the page this issue went away.

image

Example: https://beta.hardstuck.gg/gw2/builds/mesmer/condition-virtuoso/

Leg item shown as 'Legs' where it should be 'Sinister Legs' Sigil of agony name doesn't render on the dagger Precise WvW Infusion name doesn't show, only a small gray square lol

This one seems to persist after refresh: https://beta.hardstuck.gg/gw2/builds/mesmer/interrupt-mirage/ Rune of the lynx's name doens't show up, tooltip works though

SaculRennorb commented 8 months ago

Yea, so this is a bug with the php side of caching that data. It has been there since the inception of hardstuck.gg, It just usually doesn't come up since you basically are never the first one to look at any given page, but this is just what happens if the data is not in the website cache yet. Since that cache originally worked with the official api all of it is staggered asynchronous, so request don't necessarily finish before the page is displayed. In that case you get gray boxes or more general item names. Its the same issue as https://github.com/HardstuckGuild/hardstuck.gg/issues/118 which has also originally been opened here.

We might be able to fix this by using the clientside from tooltips.js to replace the incomplete texts, but this a bit of a larger undertaking.

SaculRennorb commented 2 months ago

Repaired the old client side fixing functionality in https://github.com/HardstuckGuild/hardstuck.gg/commit/991d2e0da6e7cab762e8ead72c166f028de1f074