Hareeshchandera / jsplumb

Automatically exported from code.google.com/p/jsplumb
0 stars 0 forks source link

strokeStyle needs to have default value in jsplumb 1.3.1 and Firefox 5.0.1 or error shows up #102

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
If I don't have:
jsPlumb.Defaults.EndpointStyle = { strokeStyle:'#666' };
I get error:
canvas: an attempt to set strokeStyle or fillStyle to a value that is neither a 
string, a CanvasGradient, or a CanvasPattern was ignored.

jsplumb: 1.3.1
Browser: Firefox 5.0.1
OS: Mac OS X 10.6.8

It does not show errors on Safari or Chrome 

Original issue reported on code.google.com by post2...@gmail.com on 18 Jul 2011 at 10:26

GoogleCodeExporter commented 8 years ago
what call are you making that results in this error?  

Original comment by simon.po...@gmail.com on 18 Jul 2011 at 11:36

GoogleCodeExporter commented 8 years ago
jsPlumb.addEndpoint

Original comment by post2...@gmail.com on 18 Jul 2011 at 11:39

GoogleCodeExporter commented 8 years ago
and what do you see in safari/chrome?  a black endpoint?

Original comment by simon.po...@gmail.com on 18 Jul 2011 at 11:41

GoogleCodeExporter commented 8 years ago
In firefox safari and chrome endpoints have only border.
To have color endpoints had to add css:
._jsPlumb_endpoint { 
    background-color: 'black';
}

Original comment by post2...@gmail.com on 18 Jul 2011 at 11:45

GoogleCodeExporter commented 8 years ago
strokeStyle only paints the outline of an endpoint.  fillStyle sets the fill.  

my question about safari/chrome was about when you have no default set, not 
when you have the strokeStyle set.  could you check this with your 
implementation?

Original comment by simon.po...@gmail.com on 20 Jul 2011 at 12:46

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
ok, cool, thanks for the note.

i will take a look and target 1.3.2 for this.

Original comment by simon.po...@gmail.com on 20 Jul 2011 at 1:27

GoogleCodeExporter commented 8 years ago
in 1.3.2 I have added a default fillStyle for endpoints, but _not_ strokeStyle. 
 this is because, out of the two of them, fillStyle is the one you will use 
most often with an endpoint.  strokeStyle is more of a decoration type thing.  
closing this as fixed; will be released in 1.3.2.

Original comment by simon.po...@gmail.com on 5 Aug 2011 at 5:09

GoogleCodeExporter commented 8 years ago

Original comment by simon.po...@gmail.com on 11 Aug 2011 at 3:46