search

Hareeshchandera / jsplumb

Automatically exported from code.google.com/p/jsplumb
0 stars 0 forks source link

Diamond/Arrow overlays do not fire mouse events #136

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
see here:

http://jsfiddle.net/sporritt/YkLgv/40/

event handlers registered on the 'diamond' overlay do not fire.  they probably 
should.

Original issue reported on code.google.com by simon.po...@gmail.com on 11 Oct 2011 at 10:27

GoogleCodeExporter commented 8 years ago 
i dont think this is going to make it into 1.3.4. scheduling 1.3.5 for this.

Original comment by simon.po...@gmail.com on 6 Nov 2011 at 2:39

GoogleCodeExporter commented 8 years ago 
..and moving again, to 1.3.6.  in fact, moving to no fixed target.

Original comment by simon.po...@gmail.com on 28 Jan 2012 at 11:04

GoogleCodeExporter commented 8 years ago

Original comment by simon.po...@gmail.com on 28 Jan 2012 at 11:04

GoogleCodeExporter commented 8 years ago 
Hello, I'm interested on having mouse handler on Arrow overlays.
To me it seems that moving the call to 
jsPlumb.DOMElementComponent.apply(this, arguments); 
from  jsPlumb.Overlays.Label function 
into AbstractOverlay function
would be sufficient

Am I missing the point or some side-effect of this change ??

Original comment by philippe...@gmail.com on 8 May 2012 at 2:34

GoogleCodeExporter commented 8 years ago 
DOMElementComponent is for components that are Elements, not SVG or VML.  Label 
is a div, for example.  i haven't looked at this for a while; i can't really 
remember off the top of my head what stopped me from getting it done.

Original comment by simon.po...@gmail.com on 9 May 2012 at 7:29

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
now i remember.  its the fact that i will be unable to make the canvas renderer 
work in the same way as the SVG and VML ones.  those use a separate element for 
overlays, which would give me a hook to attach an event listener.  but canvas 
only uses a separate element in the case of a Label overlay. for 
arrows/diamonds the overlay is painted as part of the connector, so i have no 
way of determining that the click was on the overlay, unless i do a bunch of 
maths, which would slow everything down.

Original comment by simon.po...@gmail.com on 14 May 2012 at 3:38

GoogleCodeExporter commented 8 years ago 
this is done for SVG and VML now.  For Canvas, the overlay is considered an 
integral part of the connector, and cannot have separate events registered on 
it.

Original comment by simon.po...@gmail.com on 23 May 2012 at 11:39