Hareeshchandera / jsplumb

Automatically exported from code.google.com/p/jsplumb
0 stars 0 forks source link

jsplumb id's on html elements #223

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Question,

I noticed the new id-adding to the HTML elements in 1.3.7. Is this a feature? 
It seems to pollute the HTML source as bit.

From the demo:
http://jsplumb.org/jquery/demo.html

the jsplumb_ id's below:

<div id="window6" class="component window <strong id="jsPlumb_1_74">Window 
6</strong>
<br id="jsPlumb_1_75">
<br id="jsPlumb_1_76">
I am plumbed with a Flowchart connector to Window 5, between our two 
centerpoints, which are drawn below, and larger than, the window element.
</div>

Original issue reported on code.google.com by j.verdur...@2bmore.nl on 12 Mar 2012 at 9:11

GoogleCodeExporter commented 8 years ago
This was not the case in 1.3.4.

Original comment by j.verdur...@2bmore.nl on 12 Mar 2012 at 9:11

GoogleCodeExporter commented 8 years ago
From reading from the code, this looks like a bug to me. 

Original comment by j.verdur...@2bmore.nl on 12 Mar 2012 at 9:13

GoogleCodeExporter commented 8 years ago
um, no, that's definitely not a feature.

Original comment by simon.po...@gmail.com on 12 Mar 2012 at 9:20

GoogleCodeExporter commented 8 years ago
it was probably introduced with the stuff that walks up the tree looking for an 
already draggable parent. i need to add an optional "doNotCreate" parameter to 
getId, i think.

Original comment by simon.po...@gmail.com on 12 Mar 2012 at 9:52

GoogleCodeExporter commented 8 years ago
fixed in 1.3.8.

this bug is a good reason to get 1.3.8 soon.  although it's not going to break 
anything, it's very invasive.

Original comment by simon.po...@gmail.com on 13 Mar 2012 at 12:30

GoogleCodeExporter commented 8 years ago
1.3.8 was released today.

Original comment by simon.po...@gmail.com on 1 Apr 2012 at 7:52

GoogleCodeExporter commented 8 years ago
Hello,

this problem is not yet solved in 1.3.8. Yes, In the HTML source those id's 
aren't visible, but I can still see them when inspecting with firebug. See your 
demo page: http://jsplumb.org/jquery/demo.html

Original comment by j.verdur...@2bmore.nl on 3 Apr 2012 at 2:37

GoogleCodeExporter commented 8 years ago
how annoying.

Original comment by simon.po...@gmail.com on 3 Apr 2012 at 9:41

GoogleCodeExporter commented 8 years ago
this is really fixed in 1.3.9.  i'll probably just release 1.3.9 in the next 
couple of days.

Original comment by simon.po...@gmail.com on 3 Apr 2012 at 10:08