search

HarelM / Android

Repository for android projects
3 stars 1 forks source link

Doesn't wake up the phone on newer versions of android #1

Open BjarkeNL opened 6 years ago

BjarkeNL commented 6 years ago

Hi!

Thank you for this cool app! I've been using it for years - best alarm clock around!

I've just upgraded from my old Samsung Galaxy S3, running Android 4.x, to a new phone, running Android 8.0.0 (Oreo). Stupid simple alarm clock has a problem on this new device. I've also tried it on a phone running Android 7 (Nougat) where it had the same problem.

Stupid simple alarm clock works well on these new phones, when i do "quick testing" (like setting the alarm to 1 minute from now, or 10 minutes from now), but when i leave the phones overnight, it does not wake up the phone to ring the alarm. It is not until you've already woken up yourself, and you turn on the screen manually, that the alarm starts ringing. (Kind of defeats the purpose of the alarm :D)

Since i love this app, i hope you will find the time to make it work for new versions of Android :)

If you need more information, feel free to ask. :)

(I do however not know what the problem is (some permission perhaps?). I think you should be able to reproduce it on any newer phone by setting the alarm over night - as mentioned, it works fine if you just set it to e.g. 10 minutes in the future)

Perhaps it's about calling .setAlarmClock() vs .setAndAllowWhileIdle() on AlarmManager? (see https://developer.android.com/reference/android/app/AlarmManager.html) Ok, i see these are methods are from a newer API, but the documentation about "low-power idle (a.k.a. doze) modes" for these and for .set() seem interesting. (Also: https://developer.android.com/training/monitoring-device-state/doze-standby.html )

Update: Perhaps this is useful: https://stackoverflow.com/questions/34378707/alarm-manager-does-not-work-in-background-on-android-6-0 and https://stackoverflow.com/a/35657293/1743225

HarelM commented 6 years ago

It has been a while since I changed the code here... I'm not even sure I have the right environment to update and test it. Nevertheless, your feedback is relevant. Can you try and see if changing the power saving mode for this app solves this issue (as a workaround). My wife has a brand new xiomi phone and it doesn't seem to suffer from this issue. Also, if you can send a pull request with the fix I can probably try and create fixed version...

BjarkeNL commented 6 years ago

Thank you for your reply. I'll try changing the power saving mode for the app, see what happens and come back to you. When/if i get the time, i'll try to implement the fix. Might take a while, though. :) (i'll probably contact you first, to make sure we're not both working on it)

BjarkeNL commented 6 years ago

An update: The workaround did work!

Also, i used a couple of hours yesterday on cloning your code, getting it up and running and modifying it to support newer versions of Android (without the workaround), and that worked too! But more testing is required. Since it's a workday tomorrow, i'll probably not have time to look at it the next few days.

HarelM commented 6 years ago

Thanks!! Take your time... Also, if you are touching it there was a problem in new versions of android since the settings menu can't be accessed from the screen (but only by long pessing the search button which is less than ideal), would be extremely helpful if you could fix that too.