Hari-Nagarajan / fairgame

Tool to help us buy hard to find items.
GNU General Public License v3.0
2.44k stars 803 forks source link

?aod=1 added at the end of URL #606

Open steccas opened 3 years ago

steccas commented 3 years ago

When the boot checks the urls it doesn't work anymore because amazon transforms the url in https://www.amazon.it/dp/ASIN?aod=1 adding the ?aod=1.

In the screen the error and the resulting browser window with this link.

Basically they added a layer that needs to be clicked once to be removed.

aod2

aod1

It can be solved simulating a click anywhere.

DakkJaniels commented 3 years ago

The code adds ?aod=1 to force the flyout open.

Will investigate clicking the page though

YangDaGod commented 3 years ago

is this an actual issue? will it prevent us from checking out? sorry i'm new here and just set everything up yesterday.

IvanShift commented 3 years ago

This is softban and the same as https://github.com/Hari-Nagarajan/fairgame/issues/599

YangDaGod commented 3 years ago

No, i dont believe it is. -I only experience the time out code when i'm running too many things at once and the system can't keep up. -The amazon page had no sellers actively selling the product that's why nothing was displayed.

you can see my url also includes ?aod=1

again i'm new to github, botting, and code but things seem to be working fine on my end.

YangDaGod commented 3 years ago

I also noticed that banning is less frequent among users if your running this in smile.amazon.com

steccas commented 3 years ago

Mmmh, yeah now that you let me notice I think that it shouldn't be a real issue. At this point it is more a thing of having the script not giving an error than anything.

YangDaGod commented 3 years ago

The time out code is also under known issues if your experiencing it while you have chrome minimized.

timeout

steccas commented 3 years ago

I forgot to specify, that it is running in headless mode. But anyways the problem is not presenting for now.

I think that it is as YangDaGod. So if we want a "solution" it can be handled the exception so no error is given. If it not worth it or you believe it shouldn't be done the issue can be closed.

pdzurina commented 3 years ago

I am running into same issue. Bot doesn't seem to even recognize if there is a stock for B083Z5P6TX item. Item was available today but it didn't even logged as available offer. Unless you guys are running your fairgames in incredible speeds on supercomputers and are able to buy items in 1 second. I wasn't able to buy anything with fairgame yet anyway as it is always too slow. However, I do see a log entries with other items when they become available. E.g.: 2021-03-25 12:07:40|0.6.2|INFO|Found 1 offers for B08L8KC1J7. Evaluating offers... 2021-03-25 12:07:40|0.6.2|INFO|Item in stock and in reserve range! 2021-03-25 12:07:40|0.6.2|INFO|662.25 + 0.00 shipping <= 900.0 2021-03-25 12:07:40|0.6.2|INFO|Adding to cart 2021-03-25 12:07:40|0.6.2|INFO|Attempting Add To Cart with offer ID... 2021-03-25 12:07:41|0.6.2|INFO|Clicking button 2021-03-25 12:07:41|0.6.2|INFO|Button clicked 2021-03-25 12:07:43|0.6.2|INFO|Looking for Proceed To Checkout button... 2021-03-25 12:07:43|0.6.2|INFO|You have no items in cart. Going back to stock check.

For some reason I only have this problem with 3060ti's specifically https://smile.amazon.com/dp/B083Z5P6TX - this is the one that occasionally goes in stock https://smile.amazon.com/dp/B083Z5P6TX?aod=1 - this is the one bot is checking and doesn't see the other one

BTW are you guys using 1-Click Option and going through "Buy Now" instead of adding to cart, clicking buttons, going to check out,...just to find out it was too slow and item is already OOS. Buy Now would have been much faster. I just need one GPU LOL

DakkJaniels commented 3 years ago

So many people suggest Buy it Now, why don't you program it then if it's so much faster and has no issues?

pdzurina commented 3 years ago

@DakkJaniels I wish I had those skills. I was looking at the code last night to see if I could modify it but this is way to evolved for my sys engineering skills. I wasn't bashing on this project at all. It's great that people get together and work on project like this. I was just merely asking a question if anyone has incorporated 1-Click option into this logic. It seems weird to me that I can buy a regular item in 6 seconds but not one GPU.

DakkJaniels commented 3 years ago

Since I can't find where I posted this before - hitting the Buy It Now button isn't 1-click. Sometimes there are other offers that pop up after you hit buy it now, that you need to hit no thanks on, sometimes some JS code needs to run, sometimes other things happen, sometimes there is nothing in the buy box or buy it now spot, but all the products are located in the offers page, sometimes etc., etc., etc.. If someone has an implementation of using buy it now that is functional and doesn't miss stuff that doesn't enter the buy box, they should submit a PR for it. Otherwise, everyone should stop suggesting it.