Hari-Nagarajan / fairgame

Tool to help us buy hard to find items.
GNU General Public License v3.0
2.44k stars 804 forks source link

Fix pipenv lock after release of Selenium 4 #832

Closed claabs closed 3 years ago

claabs commented 3 years ago

The October 13th release of selenium v4 updates its minimum requests version to >2.24.0, causing the current Pipfile to be unlockable. Setting requests = "*" allows it to resolve to 2.25.1 and lock properly.

Looking back at the commit that changed requests = "==2.24.0", it didn't seem to be for any particular reason.

We could also pin selenium to v3, however it seems to be working fine for me on v4.